Skip to content

[bitnami/prometheus-operator] add extra args for thanos sidecar #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelaeh merged 5 commits into from
Feb 27, 2020
Merged

[bitnami/prometheus-operator] add extra args for thanos sidecar #1975

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2b98cc
add extra args for thanos sidecar
ni-slamberti Feb 25, 2020
fc9198a
bump version
ni-slamberti Feb 25, 2020
2dc4c92
update chart version
ni-slamberti Feb 26, 2020
ba60588
add example comments on extraArgs section for thanos sidecar
ni-slamberti Feb 26, 2020
0da5fc1
Merge branch 'master' into extra-args
miguelaeh Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bitnami/prometheus-operator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
appVersion: 0.36.0
description: The Prometheus Operator for Kubernetes provides easy monitoring definitions for Kubernetes services and deployment and management of Prometheus instances.
name: prometheus-operator
version: 0.12.6
version: 0.12.7
Comment thread
ni-slamberti marked this conversation as resolved.
Outdated
keywords:
- prometheus
- alertmanager
Expand Down
1 change: 1 addition & 0 deletions bitnami/prometheus-operator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ The following table lists the configurable parameters of the Prometheus Operator
| `prometheus.thanos.image.tag` | Thanos image tag | `{TAG_NAME}` |
| `prometheus.thanos.image.pullPolicy` | Thanos image pull policy | `IfNotPresent` |
| `prometheus.thanos.image.pullSecrets` | Specify docker-registry secret names as an array | `[]` (does not add image pull secrets to deployed pods) |
| `prometheus.thanos.extraArgs` | Additional arguments passed to the thanos sidecar container | `[]` |
| `prometheus.thanos.service.port` | Thanos service port | `10901` |
| `prometheus.thanos.service.clusterIP` | Specific cluster IP when service type is cluster IP. Use `None` for headless service | `nil` |
| `prometheus.thanos.service.nodePort` | Kubernetes Service nodePort | `nil` |
Expand Down
3 changes: 3 additions & 0 deletions bitnami/prometheus-operator/templates/prometheus/prometheus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ spec:
- --prometheus.url=http://localhost:9090
- --grpc-address=0.0.0.0:10901
- --http-address=0.0.0.0:10902
{{- if .Values.prometheus.thanos.extraArgs }}
{{ toYaml .Values.prometheus.thanos.extraArgs | indent 8 | trim }}
{{- end }}
ports:
- name: grpc
containerPort: 10901
Expand Down
2 changes: 2 additions & 0 deletions bitnami/prometheus-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,8 @@ prometheus:
##
# pullSecrets:
# - myRegistryKeySecretName

extraArgs: []
Comment thread
ni-slamberti marked this conversation as resolved.

## Thanos Sidecar Service
##
Expand Down