Skip to content

[bitnami/harbor] Fix incorrect url generation when service.tls is enabled #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javsalgar merged 1 commit into from
Jan 29, 2020
Merged

[bitnami/harbor] Fix incorrect url generation when service.tls is enabled #1866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bitnami/harbor/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: harbor
version: 3.1.2
version: 3.1.3
appVersion: 1.10.0
description: Harbor is an an open source trusted cloud native registry project that stores, signs, and scans content
keywords:
Expand Down
2 changes: 2 additions & 0 deletions bitnami/harbor/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,6 +882,8 @@ Set the http prefix if the externalURl dont have it
{{- define "harbor.externalUrl" -}}
{{- if hasPrefix "http" .Values.externalURL -}}
{{- print .Values.externalURL -}}
{{- else if .Values.service.tls.enabled -}}
{{- printf "https://%s" .Values.externalURL -}}
{{- else -}}
{{- printf "http://%s" .Values.externalURL -}}
{{- end -}}
Expand Down