[bitnami/redis] Fix: external master host, disabling external access, configuration of replica when redis on the same k8s node and exposed outside by HostIP

[AlehYarmalovich]

Description of the change

These changes fixes:

• externalMaster - if redis/sentinels and externalMaster ports are different or exposed outside.
• When the useExternalDNS option is enabled with endpoints-type: HostIP and not set hard affinity rules, redis nodes than launch at the same k8s node as a master will be configuring as master, because equal values [[ "$REDIS_MASTER_HOST" == "$(get_full_hostname "$HOSTNAME")" ]]
• Connecting replica when disabling external redis/sentinel access.

Benefits

This solves the issue reported here
This solves the issue reported here
This solves the issue reported here

Possible drawbacks

None from the tests I performed

• Launched a new deployment with the sentinel.externalMaster parameter set to true.
• Launched a new deployment with the useExternalDNS parameter set to true, endpoints-type: HostIP and pods assign on the same k8s node.
• Launched a new deployment with the useExternalDNS parameter set to true, sentinel.service.type: NodePort and then disable external access without deliting external services.

and others tests with default values

Applicable issues

• fixes [bitnami/redis] "externalMaster" option doesn't work if redis/sentinels and externalMaster ports are different or exposed outside.  #16922
• fixes [bitnami/redis] Configuring the node as master instead as replica when redis on the same k8s node and exposed outside by HostIP #16925
• fixes [bitnami/redis] Failed to connect replica when disabling external redis/sentinel access. #16946

Additional information

Checklist

• Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
• Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
• Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
• All commits signed off and in agreement of Developer Certificate of Origin (DCO)

[AlehYarmalovich]

@migruiz4 Do you have any updates?

[migruiz4]

Hi @AlehYarmalovich,

Could you please take a look at my comments?

[AlehYarmalovich]

@carrodher Can someone assist with the review?

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

[AlehYarmalovich]

@migruiz4 Do you have any updates?

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

[github-actions]

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

[AlehYarmalovich]

Reopen