Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to recreate a deleted secret generated by the controller #963

Merged
merged 19 commits into from
Sep 27, 2022
Merged

Support to recreate a deleted secret generated by the controller #963

merged 19 commits into from
Sep 27, 2022
+137 −14

Conversation

alvneiayu
Copy link
Collaborator

Description of the change

Recreate secrets generated by the Sealed Secrets when they were deleted.

Benefits

Secrets generated by the Sealed Secrets will always be existed

Applicable issues

@alvneiayu alvneiayu temporarily deployed to vmware-image-builder September 15, 2022 15:43 Inactive
josvazg
josvazg previously approved these changes Sep 16, 2022
View reviewed changes
alemorcuq
alemorcuq suggested changes Sep 16, 2022
View reviewed changes
integration/controller_test.go Show resolved Hide resolved
pkg/controller/controller.go Outdated Show resolved Hide resolved
pkg/controller/controller.go Outdated Show resolved Hide resolved
@alvneiayu alvneiayu temporarily deployed to vmware-image-builder September 16, 2022 11:39 Inactive
@alvneiayu alvneiayu temporarily deployed to vmware-image-builder September 16, 2022 11:53 Inactive
@alvneiayu alvneiayu temporarily deployed to vmware-image-builder September 16, 2022 12:04 Inactive
alemorcuq
alemorcuq suggested changes Sep 16, 2022
View reviewed changes
integration/controller_test.go Outdated Show resolved Hide resolved
integration/controller_test.go Outdated Show resolved Hide resolved
alvneiayu and others added 2 commits September 16, 2022 14:30
@alvneiayu alvneiayu temporarily deployed to vmware-image-builder September 16, 2022 12:32 Inactive
@alvneiayu alvneiayu temporarily deployed to vmware-image-builder September 16, 2022 12:38 Inactive
josvazg
josvazg suggested changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should address those errors being shallower silently.

@alvneiayu alvneiayu temporarily deployed to vmware-image-builder September 22, 2022 13:53 Inactive
@alvneiayu alvneiayu temporarily deployed to vmware-image-builder September 22, 2022 15:12 Inactive
@josvazg josvazg self-requested a review September 22, 2022 16:02
josvazg
josvazg previously approved these changes Sep 22, 2022
View reviewed changes
@alvneiayu alvneiayu temporarily deployed to vmware-image-builder September 27, 2022 08:00 Inactive
alemorcuq
alemorcuq suggested changes Sep 27, 2022
View reviewed changes
pkg/controller/controller.go Outdated Show resolved Hide resolved
pkg/controller/controller.go Outdated Show resolved Hide resolved
pkg/controller/controller.go Outdated Show resolved Hide resolved
pkg/controller/controller.go Outdated Show resolved Hide resolved
alvneiayu and others added 5 commits September 27, 2022 10:36
@alvneiayu @alemorcuq
Use IsNotFound
5ca1f0b 
Co-authored-by: Alejandro Moreno <[email protected]>
@alvneiayu @alemorcuq
Modify log message
ac79609 
Co-authored-by: Alejandro Moreno <[email protected]>
@alvneiayu @alemorcuq
Modify log message
e0f0338 
Co-authored-by: Alejandro Moreno <[email protected]>
@alvneiayu @alemorcuq
Modify log message
856334a 
Co-authored-by: Alejandro Moreno <[email protected]>
@alvneiayu
Delete unused strings
a037d2b
@alvneiayu alvneiayu temporarily deployed to vmware-image-builder September 27, 2022 08:42 Inactive
@alvneiayu alvneiayu merged commit a5696b8 into bitnami-labs:main Sep 27, 2022
@mateuszdrab
Copy link

Hi @josvazg
Thanks for merging this, I need this feature as without it - my flux deployment doesn't work due to the secret not being recreated.
Can you advise in which release will this feature appear?

@josvazg
Copy link
Collaborator

josvazg commented Oct 6, 2022

Hi @mateuszdrab
We are working on a new formal monthly schedule for our releases, see #992

@mateuszdrab
Copy link

Hi @mateuszdrab

We are working on a new formal monthly schedule for our releases, see #992

Thank you, I've subscribed to the referenced issue and will look out for updates

This was referenced Oct 15, 2022
Closed
Closed
@armingerten armingerten mentioned this pull request Dec 2, 2022
Closed
@SreecharanChallagundla
Copy link

Please let us know if this feature is already out ... we too facing the same issue.

This was referenced Jan 23, 2023
Closed
Closed
@josvazg josvazg mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alemorcuq alemorcuq alemorcuq approved these changes

@josvazg josvazg josvazg approved these changes

@agarcia-oss agarcia-oss Awaiting requested review from agarcia-oss agarcia-oss is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deleted secrets not being recreated React to deleted secrets by re-creating them
5 participants
@alvneiayu @mateuszdrab @josvazg @SreecharanChallagundla @alemorcuq