Remove clientconfig and related global variables #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
Closed
alemorcuq
added
enhancement
backlog
josvazg
force-pushed
the
remove-client-related-globals
branch
from
b9b3df0
to
5702ecc
Compare
|
I made a mistake solving conflicts... |
alemorcuq
reviewed
Aug 4, 2022
josvazg
commented
Aug 4, 2022
Co-authored-by: Alejandro Moreno <[email protected]>
josvazg
commented
Aug 4, 2022
alemorcuq
suggested changes
Aug 4, 2022
Co-authored-by: Alejandro Moreno <[email protected]>
alemorcuq
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Remove the
clientConfigand namespace wrapper funcnamespaceFromClientConfigglobal variables.Benefits
Disentangle the code so we can make further enhancements, such as get rid of the
runmethod with a gazillion unnamed arguments.