Add extra RBAC permissions #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: juan131 <[email protected]>
juan131
requested review from
agarcia-oss,
alvneiayu and
mkmik
as code owners
Merged
This was referenced Feb 16, 2022
TheKangaroo
added a commit
to TheKangaroo/sealed-secrets
that referenced
this pull request
Apr 21, 2022
add rbac name selector for get service permission in the helm chart. this was missing in bitnami-labs#715 fixes: bitnami-labs#827 Signed-off-by: Till Adam <[email protected]>
Merged
TheKangaroo
added a commit
to TheKangaroo/sealed-secrets
that referenced
this pull request
May 5, 2022
add rbac name selector for get service permission in the helm chart. this was missing in bitnami-labs#715 fixes: bitnami-labs#827 Signed-off-by: Till Adam <[email protected]>
alemorcuq
pushed a commit
that referenced
this pull request
May 5, 2022
add rbac name selector for get service permission in the helm chart. this was missing in #715 fixes: #827 Signed-off-by: Till Adam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: juan131 [email protected]
Description of the change
This PR adds extra permissions to the ClusterRole so it can list secrets and the panic error below is addressed:
It also adds extra permissions to the "service-proxier" Role since the changes introduced at #648 require getting the service to obtain the port name information dynamically.
Benefits
Sealed Secrets to be compatible with K8s environments with RBAC enabled.
Possible drawbacks
None
Applicable issues
Additional information
N/A