-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s.io/client-go to v0.22.1 #705
Conversation
we're currently running the tests against Probably we should also add version |
roger, i'll add it here |
7a70219
to
835b846
Compare
@lrascao you probably need to bump also the Go version in
|
3b82b8e
to
7323f8d
Compare
I think we can drop support for go <1.16 We can build go 1.16 and 1.17. The go 1.18 release is behind the corner so very soon this will cover the last three versions anyway. Yeah, let's drop Go 1.14 and 1.15 |
sounds good, i'll make the changes |
7323f8d
to
da01208
Compare
should we add a |
da01208
to
9afc61a
Compare
ok, the build is good now; now the problem appears to lie in the fact that the ingegration tests are behind the |
yeah, on it now |
9afc61a
to
b2438d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM;
@juan131 this PR also changes the CI job names and requires updating the list of required CI jobs (e.g. remove Build (1.14, macos-latest)
and Build (1.15, macos-latest)
and add the 1.6 and 1.7 ones)
Awesome, thanks so much for this PR @lrascao
I totally agree, it's time to drop it.
+1 |
@@ -71,7 +77,7 @@ jobs: | |||
needs: container | |||
strategy: | |||
matrix: | |||
k8s: ["1.16.13", "1.17.11", "1.20.4"] | |||
k8s: ["1.16.13", "1.17.11", "1.20.4", "1.22.5"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks!
@lrascao the Go version needs to be updated in the release GH action too |
Single change is propagating context across all functions in order to reach k8s client api. Bump Go version to 1.16 due to io/fs import that got introduced only at this version.
b2438d4
to
f2fdc9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the change
Bump k8s client api to v0.22.1, single change is propagating context across all functions in order to
reach k8s client api.
Benefits
Allows k8s controllers to use sealed secrets client API when running on newer more recent versions.
Possible drawbacks
Do not foresee any, single change is context propagation.