Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binaries to emit the proper version #683

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

juan131
Copy link
Collaborator

@juan131 juan131 commented Dec 16, 2021

Signed-off-by: juan131 [email protected]

Description of the change

Binaries are reported UNKNOWN when asked after delegating the compilation to Goreleaser.

Benefits

Binaries report the proper version.

Possible drawbacks

None

Applicable issues

Additional information

N/A

Copy link
Collaborator

@alvneiayu alvneiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@agarcia-oss agarcia-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, thanks!

@juan131 juan131 merged commit 8f7f091 into bitnami-labs:main Dec 16, 2021
@juan131 juan131 deleted the binaries-version branch December 16, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubeseal --version broken in v0.17.0
3 participants