Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use networking.k8s.io/v1 for Ingress if possible #641

Closed
wants to merge 1 commit into from
Closed

Use networking.k8s.io/v1 for Ingress if possible #641

wants to merge 1 commit into from

Conversation

farodin91
Copy link
Contributor

Fixes #639

@tewfik-ghariani
Copy link
Contributor

Any idea when will this get merged?

cc @mkmik

@sathieu
Copy link
Contributor

sathieu commented Oct 6, 2021

I have the same problem for another PR (#635). Anyone reviewing here?

mkilchhofer
mkilchhofer suggested changes Oct 14, 2021
View reviewed changes
Copy link

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I also wanted to contribute. :-) Could you use the new Capabilities.KubeVersion or Capabilities.KubeVersion.Version? The existing .Capabilities.KubeVersion.GitVersion is deprecated.

Ref: https://helm.sh/docs/chart_template_guide/builtin_objects/

@janosbinder janosbinder mentioned this pull request Oct 15, 2021
Closed
@jpetazzo jpetazzo mentioned this pull request Nov 4, 2021
Closed
@farodin91
Copy link
Contributor Author

Updated

@kobejn-jb
Copy link

I'm using this chart and having this released would be really useful.
Can some maintainer review this?

@davidkarlsen
Copy link
Contributor

@mkmik PTAL? This will be required for running on k8s 1.22

@juan131
Copy link
Collaborator

juan131 commented Dec 16, 2021

We're performed a major refactorization of the chart at #687 today, see:

$ helm repo update sealed-secrets
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "sealed-secrets" chart repository
Update Complete. ⎈Happy Helming!⎈
$  helm search repo sealed-secrets/sealed-secrets
NAME                         	CHART VERSION	APP VERSION	DESCRIPTION
sealed-secrets/sealed-secrets	2.0.0        	v0.17.1    	Helm chart for the sealed-secrets controller.

This new chart version should already tackle this. Could you please give it a try?

@juan131
Copy link
Collaborator

juan131 commented Dec 23, 2021

I proceed to close this PR since it's already addressed at #687. Feel free to reopen if you consider this requires further discussion.

@juan131 juan131 closed this Dec 23, 2021
@juan131 juan131 self-assigned this Dec 23, 2021
@juan131 juan131 added the bug label Dec 23, 2021
@farodin91 farodin91 deleted the ingress-v1 branch December 23, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sathieu sathieu sathieu left review comments

@mkilchhofer mkilchhofer mkilchhofer requested changes

Assignees

@juan131 juan131

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Helm] Ingress apiVersion to support "networking.k8s.io/v1"
7 participants
@farodin91 @tewfik-ghariani @sathieu @kobejn-jb @davidkarlsen @juan131 @mkilchhofer