Add label-selector to filter sealed secrets #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you! integration tests are broken at the moment. |
mkmik
approved these changes
Feb 12, 2021
Allow filtering which sealed secrets this controller acts on by passing in a label selector.
|
thanks! could you also please add a test case for this? |
|
Hey, yeah I commented about this on slack, but I'll mention here too: do you have a suggestion for how/where to add the test? Ideally the controller would be tested with and without the filter option, but this would require deploying two different versions of the controller, and potentially two separate integration tests. |
|
yeah; let's see how we currently test the ( |
🤦 we don't test it; I guess it's a similar problem |
|
ok; let's land this and open a separate issue about testing different configuration of the controller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow filtering which sealed secrets this controller acts on by passing in a label selector.