Adding keyttl and keycutofftime options to helm chart #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rurod <[email protected]>
rurod
force-pushed
the
enhancement/helm-tpl-key-options
branch
from
3b4d673 to
40e94cd
Compare
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
alvneiayu
approved these changes
Nov 5, 2024
alvneiayu
approved these changes
Nov 5, 2024
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Dec 6, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [bitnami-labs/sealed-secrets](https://github.com/bitnami-labs/sealed-secrets) | patch | `v0.27.2` -> `v0.27.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>bitnami-labs/sealed-secrets (bitnami-labs/sealed-secrets)</summary> ### [`v0.27.3`](https://github.com/bitnami-labs/sealed-secrets/blob/HEAD/RELEASE-NOTES.md#v0273) [Compare Source](bitnami-labs/sealed-secrets@v0.27.2...v0.27.3) - Bump k8s.io/apimachinery from 0.31.2 to 0.31.3 ([#​1642](bitnami-labs/sealed-secrets#1642)) - Bump k8s.io/code-generator from 0.31.2 to 0.31.3 ([#​1643](bitnami-labs/sealed-secrets#1643)) - Bump github.com/onsi/gomega from 1.35.1 to 1.36.0 ([#​1645](bitnami-labs/sealed-secrets#1645)) - re-introduce install instructions with to releases ([#​1649](bitnami-labs/sealed-secrets#1649)) - Properly error out when input file doesn't exist ([#​1640](bitnami-labs/sealed-secrets#1640)) - Bump github.com/onsi/ginkgo/v2 from 2.21.0 to 2.22.0 ([#​1641](bitnami-labs/sealed-secrets#1641)) - Bump golang.org/x/crypto from 0.28.0 to 0.29.0 ([#​1635](bitnami-labs/sealed-secrets#1635)) - Configure max retries ([#​1633](bitnami-labs/sealed-secrets#1633)) - Label "app.kubernetes.io/instance" in the Prometheus metric ([#​1620](bitnami-labs/sealed-secrets#1620)) - Bump github.com/onsi/gomega from 1.34.2 to 1.35.1 ([#​1624](bitnami-labs/sealed-secrets#1624)) - Adding keyttl and keycutofftime options to helm chart ([#​1610](bitnami-labs/sealed-secrets#1610)) - Bump github.com/onsi/ginkgo/v2 from 2.20.2 to 2.21.0 ([#​1623](bitnami-labs/sealed-secrets#1623)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Hi, this change adds the two following controller flags as options in the helm chart :
Benefits
It allows specifying those options without having to override the default args list defined by the helm chart.
Thus simplifying the early key renewal procedure when Sealed Secrets is deployed through ArgoCD for example.
Possible drawbacks
No drawback identified.
Applicable issues
Did not find an opened issue mentioning this.
Additional information
N/A