fix: remove trailing dashes for multidoc yaml the pragmatic way #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bitnami-labs#1330 bitnami-labs#1296 Signed-off-by: Tim Heurich <[email protected]>
theurichde
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
|
Can we have a 0.24.1 release with this fix? 0.24 broke all my deployment scripts |
|
hi @davhdavh We will release a new version in the following hours. Thanks Álvaro |
|
Thank you for fixing this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1330 #1296
Description of the change
While introducing multi document support for JSON and YAML, we introduced trailing dashes for YAMLs, which violates the YAML specification. This change will add
---before every YAML documentBenefits
YAML specification is met, linters will be happy.
Possible drawbacks
Applicable issues
kubesealappends extra document separator---when format is YAML #1330kubesealadds trailing newline to YAML output #1296Additional information