-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multidoc support for yaml and json #1304
feat: multidoc support for yaml and json #1304
Conversation
Hi there 👋🏻 @alvneiayu @agarcia-oss @alemorcuq I would like to have your feedback on this draft before raising the actual PR. Any thoughts on this approach? |
thanks for your contribution @theurichde. Let me take some time to test it and review it. Again, thanks a lot. |
Thanks for the PR, @theurichde. Could you please check the failed linter job? The feature looks good! |
Hey there @alvneiayu @alemorcuq 👋🏻 Linting is fixed, should be green now. I am wondering if we should put that feature somewhere (as a side note?) in the README? Maybe in the FAQ? For Example:
|
Yep, I think that would be great! |
@alemorcuq I added a small block for multi doc support in the FAQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great PR, @theurichde, thank you very much. It is ready to be merged but, due to some recent changes, a rebase is needed. Could you do that?
bea19e6
to
f7eaabe
Compare
Fixes bitnami-labs#114 Signed-off-by: Tim Heurich <[email protected]>
Fixes bitnami-labs#114 Signed-off-by: Tim Heurich <[email protected]>
Fixes bitnami-labs#114 Signed-off-by: Tim Heurich <[email protected]>
Signed-off-by: Tim Heurich <[email protected]>
Signed-off-by: Tim Heurich <[email protected]>
Signed-off-by: Tim Heurich <[email protected]>
Signed-off-by: Tim Heurich <[email protected]>
f7eaabe
to
2a5f302
Compare
@alemorcuq Thanks for reviewing! It's rebased and ready to rock 🤘🏻 |
Description of the change
Add Support for Multidoc YAML and JSON, as stated in #114
Benefits
Users can have and manage multiple secrets in one file and encrypt those secrets in one run
Possible drawbacks
This change does not apply to
--merge-into
Kind: List
resources are not considered / supportedApplicable issues
Additional information
I want to get your opinion on this approach and see if I am on the right track here.