Add missing document seperator #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxWinterstein
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
|
Hi @MaxWinterstein we're reviewing this PR, thanks for your patience. Meanwhile, can you please include a sign-off to your commit? We have instructions for that in our CONTRIBUTING guidelines. |
Signed-off-by: Max Winterstein <[email protected]>
MaxWinterstein
force-pushed
the
max-missing-seperator
branch
from
371e3ad
to
e98bc77
Compare
|
Added the signoff as requested. |
agarcia-oss
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fix documentation for users that ever installed sealed-secrets older than version 0.9.x on their cluster.
Benefits
Documentation now lead to a working key restore.
Possible drawbacks
None.
Applicable issues
Might be related to #923
Additional information
Currently the documentation simply redirects the second output of
kubectl get secretsat the end of the first.This leads to 'kinda' broken yaml, as there is no document seperator. The key is just added to the last key in the file.
As a result , the
sealed-secrets-keywon't be added to the server. So pretty old secrets can't get decrypted.Fixing this is easy, by just adding the 'thre-dot-seperator' to the document. Now the old key gets created nicely and everything is fine.
I am not sure why there is no seperator at first, or if kubectl got rid of them.