Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additionalPrinterColumns for status and age #1217

Merged

Conversation

kvandenhoute
Copy link
Contributor

@kvandenhoute kvandenhoute commented May 17, 2023

Signed-off-by: Karel Vanden Houte [email protected]

Description of the change

This is a change to the SealedSecret CRD. It will add a column "Status" and "Synced" with the latest status (message & status) of a secret.
Before, when doing kubectl get sealedsecret you would see:

NAME          AGE
my-secret     6m35s

After this change, you will see:

NAME        STATUS                                   SYNCED   AGE
my-secret   no key could decrypt secret (password)   False    25m

Benefits

You can see the status of your secrets easier. When you have a lot of secrets in a cluster and would like to see which ones can't be decrypted, this comes in handy.

Possible drawbacks
None AFAIK

Applicable issues

Additional information

Signed-off-by: Karel Vanden Houte <[email protected]>
@stgrace
Copy link

stgrace commented May 17, 2023

What a beautiful QOL change there @kvandenhoute!

Copy link
Collaborator

@alemorcuq alemorcuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! Thanks!

Copy link
Collaborator

@alemorcuq alemorcuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run make generate and make manifests and commit the changes too?

Signed-off-by: Karel Vanden Houte <[email protected]>
@kvandenhoute
Copy link
Contributor Author

make generate generated quite some diffs that I know nothing about so decided not to push these.

@alemorcuq alemorcuq merged commit 313ab87 into bitnami-labs:main May 18, 2023
@alemorcuq
Copy link
Collaborator

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants