Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sealed secrets to Go 1.20 #1173

Merged
merged 1 commit into from
Apr 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
matrix:
go: ${{ fromJSON(needs.load-versions.outputs.go_version_list) }}
os: [ubuntu-latest]
golangci-lint: ["1.49.0"]
golangci-lint: ["1.52.2"]
steps:
- name: Set up Go 1.x
uses: actions/[email protected]
Expand All @@ -64,7 +64,7 @@ jobs:
matrix:
go: ${{ fromJSON(needs.load-versions.outputs.go_version_list) }}
os: [ubuntu-latest]
gosec: ["2.12.0"]
gosec: ["2.15.0"]
steps:
- name: Set up Go 1.x
uses: actions/[email protected]
Expand Down
1 change: 1 addition & 0 deletions cmd/kubeseal/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ func runCLI(w io.Writer, cfg *config) (err error) {
if err != nil {
return err
}
// #nosec: G307 -- this deferred close is fine because it is not on a writable file
defer f.Close()

if flags.dumpCert {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/bitnami-labs/sealed-secrets

go 1.19
go 1.20
josvazg marked this conversation as resolved.
Show resolved Hide resolved

require (
github.com/google/go-cmp v0.5.9
Expand Down
2 changes: 1 addition & 1 deletion versions.env
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
GO_VERSION=1.19.4
GO_VERSION=1.20.3
GO_VERSION_LIST="[\"$GO_VERSION\"]"