Fix empty Group Version Kind #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
Signed-off-by: Jose Luis Vazquez Gonzalez <[email protected]>
josvazg
force-pushed
the
fix-empty-gvk
branch
from
d1e6138
to
105d5c6
Compare
Signed-off-by: Jose Luis Vazquez Gonzalez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fix empty Group Version Kind fields which can happen at times. See:
operator-framework/operator-sdk#727
Some typos have also been opportunistically fixed.
Benefits
The Object is completed at generation/cast time, so it can be relied to be completed later on.