Remove namespaceFn #1029
Merged
Remove namespaceFn #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
Signed-off-by: Jose Luis Vazquez Gonzalez <[email protected]>
josvazg
force-pushed
the
remove-namespace-fn
branch
from
907b605
to
eb35c80
Compare
agarcia-oss
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This configurable function behavior was only used on a test and otherwise making the production code more complex for no good reason.
This change removes the function definition and instead uses an interface to overload the behavior of the
clientConfigto ensure the test was still behaving the same way.Benefits
Simpler code that is easier to be further evolved and inproved.