Reduce CTE strategy usage when not needed (#292)

bitmagnet-io · Jul 4, 2024 · 6cf825b · 6cf825b
1 parent abdb714
commit 6cf825b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/internal/database/query/query.go b/internal/database/query/query.go
@@ -717,13 +717,10 @@ func (b optionBuilder) shouldTryCteStrategy() bool {
 	if !b.limit.Valid || len(b.orderBy) == 0 {
 		return false
 	}
-	if b.tsquery != "" {
-		return true
-	}
 	for _, f := range b.facets {
 		if f.TriggersCte() && len(f.Filter()) > 0 {
 			return true
 		}
 	}
-	return false
+	return b.tsquery != "" && (len(b.orderBy) != 1 || b.orderBy[0].Column.Name != QueryStringRankField || !b.orderBy[0].Desc)
 }
diff --git a/internal/database/search/facet_torrent_content_type.go b/internal/database/search/facet_torrent_content_type.go
@@ -17,7 +17,6 @@ func TorrentContentTypeFacet(options ...query.FacetOption) query.Facet {
 					query.FacetHasKey(TorrentContentTypeFacetKey),
 					query.FacetHasLabel("Content Type"),
 					query.FacetUsesOrLogic(),
-					query.FacetTriggersCte(),
 				}, options...)...,
 			),
 			field: func(q *dao.Query) field.Field {