Script for creating Debian package #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure we'd merge this, but I'll comment on some script bugs anyway :) |
| ARCH=$2 | ||
|
|
||
| # Fail early | ||
| set -e errexit |
There was a problem hiding this comment.
you mean set -o errexit. that's equivalent to set -e. Also, if you use the long-name form, the comment is superfluous
Valid points all of em. Made changes accordingly. Let me know if you think I'm missing something else - or feel free to close this pull request ;) |
|
I am no longer using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed it simplify deployment. Maybe could be of use for someone else, don't know.