Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark tests for process*(...) #23

Merged
merged 1 commit into from
Nov 12, 2013
Merged

Conversation

JensRantil
Copy link
Contributor

I wrote a couple of benchmarks for statsdaemon and thought that they maybe could be of interest to enable people to test throughput and potential speed improvements. Let me know whether you find them useful or not.

@mreiferson
Copy link
Contributor

these look good, thanks!

mind posting the output of the benchmark on this PR for posterity?

@JensRantil
Copy link
Contributor Author

You're welcome!

mind posting the output of the benchmark on this PR for posterity?

Sure!

$ go test -bench=".*"
PASS
BenchmarkManyDifferentSensors          1    2014624926 ns/op
BenchmarkOneBigTimer           1    1958929096 ns/op
BenchmarkLotsOfTimers          1    2012189938 ns/op
ok      github.com/bitly/statsdaemon    12.082s

I've also played around with making the processing more concurrent. It's yielded a speedup, but at the cost of code readability. If you are curious, you can have a look here.

@mreiferson
Copy link
Contributor

Thanks. Feel free to open up a separate PR for the performance improvements so we can take a look.

This PR just needs a rebase from the recent merges...

@JensRantil
Copy link
Contributor Author

Thanks. Feel free to open up a separate PR for the performance improvements so we can take a look.

Will do in a sec.

This PR just needs a rebase from the recent merges...

Rebase done. Should be mergable now.

@JensRantil
Copy link
Contributor Author

Will do in a sec.

I seem to have a couple of conflicts. Will submit hopefully tomorrow.

@mreiferson
Copy link
Contributor

looks like travis is reporting test failures on this branch...

@JensRantil
Copy link
Contributor Author

looks like travis is reporting test failures on this branch...

Fixed. My bad. Usually I get an e-mail when Travis is failing. Not sure why I didn't this time.

mreiferson added a commit that referenced this pull request Nov 12, 2013
Benchmark tests for `process*(...)`
@mreiferson mreiferson merged commit 0091fef into bitly:master Nov 12, 2013
@JensRantil JensRantil deleted the benchmarks branch November 12, 2013 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants