This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Connections queue support #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this the same as pull request 45, #45 ? |
|
@FlorianLudwig It solve the same problem, but the implementation it's a little bit different (In this one, the connection is taken on the releasing event, IMHO it's a little bit efficient) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of raise the TooManyConnections exception when maxconnections is reached, the outgoing requests will be queued until a slot become free.
I faced a problem regarding this issue on a high concurrency scenario, I did some tests and seems to work properly.