-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docker/terraform deployment #415
Merged
ezewer
merged 17 commits into
bitfinexcom:staging
from
ZIMkaRU:feature/improve-docker-terraform-deployment
Sep 13, 2024
Merged
Improve docker/terraform deployment #415
ezewer
merged 17 commits into
bitfinexcom:staging
from
ZIMkaRU:feature/improve-docker-terraform-deployment
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release version to master
ezewer
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
docker
/terraform
deploymentBasic changes:
html-pdf
module usage under Docker container with using docker container based on theDebian
image to make html-pdf module workable, uses official image https://hub.docker.com/_/nodeREADME
setup
/deploy
/launch
scripts to be able to use independent installed Docker Compose withdocker-compose
cli and the new one withdocker compose
as a part of the latest Docker distributionvpc
module to improve default network controlAWS
provider versionterraform
versionUbuntu
version up to24.04
forEC2
instancessm
parameter if the name existsrandom_password
resource