Bring rails4-support branch changes to master #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add NotFoundError that raise when a model is not found
Allows nil for belongs_to
matiasgarcia
changed the title
werner
approved these changes
Jan 11, 2021
fwelschen
approved these changes
Jun 14, 2022
tmsrjs
reviewed
Jun 14, 2022
| @@ -42,12 +42,24 @@ def valid? | |||
| def self.where(*args) | |||
| all | |||
| end | |||
|
|
|||
| def ==(other) | |||
| other.try(:id) == id | |||
There was a problem hiding this comment.
Shouldn't we check for class equality too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterwas missing some changes from therails4-supportbranch that had changes being used at Bitex.