health dashboards: remove path templatization logic #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murki
reviewed
Aug 28, 2024
| putOptional(HttpFieldKey.QUERY, response.query) | ||
| internal val fields: InternalFieldsMap = | ||
| run { | ||
| val fields = buildMap { |
There was a problem hiding this comment.
this code is very hard to reason about, can you add some comments about what you're trying to achieve here?
murki
reviewed
Aug 28, 2024
platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/network/HttpResponseInfo.kt
Outdated
Show resolved
Hide resolved
murki
approved these changes
Aug 28, 2024
| val normalized: String? = requestPathTemplate?.let { it } | ||
| ?: it.template?.let { it } | ||
| ?: try { | ||
| CaptureJniLibrary.normalizeUrlPath(it.value) |
There was a problem hiding this comment.
it's great to be able to get rid of this call
| @@ -125,7 +125,6 @@ class CaptureLoggerTest { | |||
| "_host" to "api.bitdrift.io", | |||
| "_method" to "GET", | |||
| "_path" to "/my_path/12345", | |||
| "_path_template" to "/my_path/<id>", | |||
There was a problem hiding this comment.
can we now remove the CaptureJniLibrary.load() and maybe even make it a plain unit test (vs robolectric one)?
There was a problem hiding this comment.
not this particular test, it starts a test server and does depend on some native code. I removed CaptureJniLibrary.load from three other places tho.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan is to make this logic remote configuration configurable and move the actual implementation of the feature to shared-core repo instead.