Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[andr][releases] Include sources.jar artifact in maven releases #64

Merged

Conversation

murki
Copy link
Contributor

@murki murki commented Oct 4, 2024

Since the source is now available we should include the sources jar for ease of development and debugging on consumer apps.

@murki murki requested a review from Augustyniak October 4, 2024 21:29
@@ -64,6 +64,7 @@ function release_capture_sdk() {
"$sdk_repo/ci/NOTICE.txt" \
"$name.pom" \
"$name-javadoc.jar" \
"$name-sources.jar" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Augustyniak I assume this is all I need to do since by looking at the logs it seems we do download and unzip the sources from gh here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that should do it

@murki murki merged commit 5c41658 into main Oct 4, 2024
14 checks passed
@murki murki deleted the murki/bit-3613-include-sources-artifacts-in-android-releases branch October 4, 2024 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants