split xcode test target into two #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augustyniak
commented
Oct 4, 2024
| bufferDirectory: url, | ||
| // swiftlint:disable:next force_unwrapping | ||
| apiURL: URL(string: "https://localhost:\(port)")!, | ||
| remoteErrorReporter: nil, | ||
| configuration: configuration, | ||
| sessionProvider: InMemorySessionProvider(sessionIDGenerator: { UUID().uuidString }), | ||
| sessionStrategy: .fixed(), |
There was a problem hiding this comment.
I noticed that benchmark app was broken so fixed it in here
murki
approved these changes
Oct 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BIT-3772
The new test organization will simplify running "core" tests and "URLSession integration" tests separately. This is important because the "URLSession integration" tests take longer and require real network requests (something we may consider optimizing in the future).
With "core" tests as a separate target, it should be easier to run tests while developing locally.
The changes are mostly reorganizational. The old "test" target was split into 3 targets:
URLSessionintegration tests