handle logger creation failures #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murki
reviewed
Oct 1, 2024
| /** | ||
| * Used for testing purposes. | ||
| */ | ||
| internal fun resetShared() { |
There was a problem hiding this comment.
nowhere, leftover that I thought I removed. Removing for real time time...
There was a problem hiding this comment.
actually, re-added it to fix flakiness of CaptureTest.kt tests
murki
reviewed
Oct 1, 2024
platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/Capture.kt
Outdated
Show resolved
Hide resolved
murki
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
by always catching at construction time you might've "fixed" other cases where the context.getSystemService might be null (see BIT-3712). Should be ok although we now incur the cost of shutting down the entire logger when the better solution would be to only shutdown the dependent ListenerLogger
…re.kt Co-authored-by: Miguel Juárez López <[email protected]> Signed-off-by: Rafał Augustyniak <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make platform layer handle cases where a Rust call to create a logger fails.
The way the logic works is that after the first time
Logger.configurefails the consecutive attempts to configure the logger are no-ops. There is a public API change introduces in this PR on Android.Logger.configure(...)method returns an optionalLoggerIntegratorobject that used to be non-optional. For this reason, the next release will be 0.15.0.Fixes BIT-3752