Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[andr][ci] fix android runners #227

Merged
merged 2 commits into from
Feb 17, 2025
Merged

[andr][ci] fix android runners #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe8479a
Superfluous change to trigger the ci breakage
murki Feb 17, 2025
1b5e3c0
try [email protected]
murki Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/android.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
- name: Create AVD and generate snapshot for caching
if: steps.avd-cache.outputs.cache-hit != 'true'
timeout-minutes: 30
uses: reactivecircus/android-emulator-runner@f0d1ed2dcad93c7479e8b2f2226c83af54494915 # pin@v2.32
uses: reactivecircus/android-emulator-runner@62dbb605bba737720e10b196cb4220d374026a6d # pin@v2.33
with:
channel: stable
force-avd-creation: false
Expand All @@ -139,7 +139,7 @@ jobs:
working-directory: ./platform/jvm
run: ./gradlew replay:checkLicense common:checkLicense # capture:checkLicense doesn't work at the moment
- name: Instrumentation Tests
uses: reactivecircus/android-emulator-runner@f0d1ed2dcad93c7479e8b2f2226c83af54494915 # pin@v2.32
uses: reactivecircus/android-emulator-runner@62dbb605bba737720e10b196cb4220d374026a6d # pin@v2.33
with:
channel: stable
force-avd-creation: false
Expand Down Expand Up @@ -187,7 +187,7 @@ jobs:
- name: Create AVD and generate snapshot for caching
if: steps.avd-cache.outputs.cache-hit != 'true'
timeout-minutes: 30
uses: reactivecircus/android-emulator-runner@d94c3fbe4fe6a29e4a5ba47c12fb47677c73656b # pin@v2
uses: reactivecircus/android-emulator-runner@62dbb605bba737720e10b196cb4220d374026a6d # pin@v2.33
with:
channel: stable
api-level: ${{ matrix.api-level }}
Expand All @@ -199,7 +199,7 @@ jobs:
emulator-options: -no-window -accel on -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
script: echo "Generated AVD snapshot for caching."
- name: run tests
uses: reactivecircus/android-emulator-runner@v2
uses: reactivecircus/android-emulator-runner@62dbb605bba737720e10b196cb4220d374026a6d # [email protected]
timeout-minutes: 15
with:
force-avd-creation: false
Expand Down
6 changes: 3 additions & 3 deletions platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/threading/CaptureDispatchers.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,17 @@ internal sealed class CaptureDispatchers private constructor(
/**
* [ExecutorService] A common background single thread worker that will be used to process events sequentially
*/
object CommonBackground : CaptureDispatchers("background-thread-worker")
data object CommonBackground : CaptureDispatchers("background-thread-worker")

/**
* [ExecutorService] to be used for networking capture
*/
object Network : CaptureDispatchers("network.okhttp")
data object Network : CaptureDispatchers("network.okhttp")

/**
* [ExecutorService] to be used for Session-Replay
*/
object SessionReplay : CaptureDispatchers("session-replay")
data object SessionReplay : CaptureDispatchers("session-replay")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated superfluous improvement to trigger the ci builds


private fun buildExecutorService(threadName: String): ExecutorService =
Executors.newSingleThreadExecutor {
Expand Down
Loading