support two modes of okhttp instrumentation via plugin + wire up release pipeline #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowp
commented
Dec 8, 2024
| "$sdk_repo/ci/LICENSE.txt" \ | ||
| "$sdk_repo/ci/NOTICE.txt" \ | ||
| ) | ||
| cp "$sdk_repo/capture-timber.zip" "$sdk_repo/capture-timber-$version.android.zip" |
There was a problem hiding this comment.
This has the implication that we will now include checksum files in the GH release zips for timber/plugin which isn't ideal but I don't think anyone relies on the GH releases so seems fine until we can simplify the deployment pipeline further
There was a problem hiding this comment.
that should be fine, arguably any artifact bundle can benefit from including checksums
murki
reviewed
Dec 9, 2024
| - name: Compress Plugin artifacts | ||
| run: | | ||
| readonly dir=$(pwd) | ||
| (cd capture-plugin/build/repos/releases/io/bitdrift/capture-plugin/${{ inputs.version }} && zip -r "$dir/capture-plugin.zip" ./*) |
There was a problem hiding this comment.
I'm pretty sure the upload artifacts job already compresses all the files in a folder, not sure why we had this compression step to being with
There was a problem hiding this comment.
also aren't you missing a step to run run: ./gradlew :capture-plugin:publish ??
murki
approved these changes
Dec 9, 2024
murki
reviewed
Dec 9, 2024
| popd | ||
| } | ||
|
|
||
| release_capture_sdk |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release pipeline updated to support multiple additional artifacts, in this case: