Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send device model in handshake and error reports #143

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

mattklein123
Copy link
Contributor

@mattklein123 mattklein123 commented Dec 8, 2024

Also bump shared core to bring in previous disconnection reason change in API.

Fixes BIT-4172

Also bump shared core to bring in previous disconnection
reason change in API.

Signed-off-by: Matt Klein <[email protected]>
@mattklein123 mattklein123 requested review from murki and snowp December 8, 2024 17:46
Signed-off-by: Matt Klein <[email protected]>
Copy link
Contributor

@murki murki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits, looks fine otherwise

Signed-off-by: Matt Klein <[email protected]>
@mattklein123 mattklein123 enabled auto-merge (squash) December 9, 2024 18:00
@mattklein123 mattklein123 merged commit abc207b into main Dec 9, 2024
15 checks passed
@mattklein123 mattklein123 deleted the model branch December 9, 2024 18:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants