Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove magic okhttp interceptors #131

Merged
merged 3 commits into from
Nov 26, 2024
Merged

remove magic okhttp interceptors #131

merged 3 commits into from
Nov 26, 2024

Conversation

snowp
Copy link
Contributor

@snowp snowp commented Nov 26, 2024

No description provided.

murki
murki approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@murki murki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm a little wary of potentially affecting customers' interceptors but we can test whether that's true

@snowp
Copy link
Contributor Author

snowp commented Nov 26, 2024

This should only really affect the OkHttpClient that we create internally to the API client, so the main thing we are protecting against is extra interceptors added to our client that we have no guarantee will work correctly

@snowp snowp merged commit 959fc7d into main Nov 26, 2024
15 checks passed
@snowp snowp deleted the remove-interceptors branch November 26, 2024 21:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@murki murki murki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snowp @murki