[ANDR][Replay] Flatten and de-spaghettize Session Replay logic #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augustyniak
approved these changes
Nov 12, 2024
| import java.util.concurrent.TimeUnit | ||
|
|
||
| /** | ||
| * Allows to capture the screen and send the binary data over a persistent websocket connection | ||
| * @param replayModule The replay module to use for screen capture | ||
| * @param replayManager The replay module to use for screen capture |
There was a problem hiding this comment.
this seems off (there are missing docs for other arguments as well)
There was a problem hiding this comment.
yeah i noticed the entire replay module is whack and docs are not enforced. i'll look into fixing all that in a separate pr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding screenshotting capabilities.
Classes in the replay module were over-abstracted and all their dependencies were leaking so we're refactoring it all to flatten and simplify their structures and make their dependancies be enforced at construction time.