Revert portion of "[Andr][CI] Pom improvements (#103)" #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0d1a736.
snowp
approved these changes
Nov 7, 2024
murki
reviewed
Nov 7, 2024
| @@ -119,8 +113,3 @@ publishing { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // TODO(murki): Using this requires further setup in CI and local (e.g. signing entries in the local gradle.properties file) | |||
| signing { | |||
There was a problem hiding this comment.
you can also just comment this section out
There was a problem hiding this comment.
since this is the error
Execution failed for task ':capture-timber:signMavenPublication'.
> Task :capture-timber:signMavenPublication FAILED
> Cannot perform signing task ':capture-timber:signMavenPublication' because it has no configured signatory
and I haven't set up that part yet
There was a problem hiding this comment.
kk, will do that
Augustyniak
changed the title
This reverts commit 94e9981.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0d1a736.
Reverting #103 as it caused release failure. Example https://github.com/bitdriftlabs/capture-sdk/actions/runs/11725381311/job/32661563447