Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios: lower example app iOS target to iOS 14 #106

Merged
merged 2 commits into from
Nov 7, 2024
Merged

ios: lower example app iOS target to iOS 14 #106

merged 2 commits into from
Nov 7, 2024

Conversation

Augustyniak
Copy link
Contributor

@Augustyniak Augustyniak commented Nov 7, 2024 •
edited
Loading

  1. Change the APIs used to render Configurations screen so that it's possible to target iOS 14 as opposed to iOS 16. Fixed build issue as the one in https://github.com/bitdriftlabs/capture-sdk/actions/runs/11707493222/job/32607029804.
  2. Remove assertion on accessing a shared logger since it doesn't benefit our customers in any way (assertions are compiled out of prod builds of the SDK) and can hurt local dev.
Before After
Simulator Screenshot - iPhone 15 Pro - 2024-11-07 at 09 12 44 Simulator Screenshot - iPhone 15 Pro - 2024-11-07 at 09 07 13

@Augustyniak Augustyniak enabled auto-merge (squash) November 7, 2024 14:31
@Augustyniak Augustyniak merged commit 223ff52 into main Nov 7, 2024
14 checks passed
@Augustyniak Augustyniak deleted the lower-example-app-target-to-ios-13 branch November 7, 2024 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacksonhardaker jacksonhardaker jacksonhardaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Augustyniak @jacksonhardaker