bazel lint

bitdriftlabs · Feb 10, 2025 · 6aaec22 · 6aaec22
1 parent 96fb371
commit 6aaec22
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 3 deletions.
diff --git a/MODULE.bazel b/MODULE.bazel
@@ -58,6 +58,7 @@ bazel_dep(name = "flatbuffers", version = "24.3.25")
 bazel_dep(name = "platforms", version = "0.0.11")
 bazel_dep(name = "rules_kotlin", version = "2.0.0")
 bazel_dep(name = "rules_rust", version = "0.56.0")
+bazel_dep(name = "rules_shell", version = "0.4.0")
 
 # Requiered by android_artifacts for pom_file, it's not in bazel central registry
 bazel_dep(name = "google_bazel_common", version = "0.0.1")

diff --git a/MODULE.bazel.lock b/MODULE.bazel.lock
diff --git a/bazel/android/dokka.bzl b/bazel/android/dokka.bzl
@@ -1,3 +1,5 @@
+load("@rules_java//java/common:java_common.bzl", "java_common")
+
 def _sources_javadocs_impl(ctx):
     javabase = ctx.attr._javabase[java_common.JavaRuntimeInfo]
     plugins_classpath = ";".join([

diff --git a/bazel/android_debug_info.bzl b/bazel/android_debug_info.bzl
@@ -9,6 +9,9 @@ But even if we could create those we'd need to get them out of the build
 somehow, this rule provides a separate --output_group for this
 """
 
+load("@rules_cc//cc/common:cc_common.bzl", "cc_common")
+load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
+
 def _impl(ctx):
     library_outputs = []
     objdump_outputs = []

diff --git a/bazel/ios/BUILD b/bazel/ios/BUILD
@@ -1,4 +1,5 @@
 load("@rules_apple//apple:apple.bzl", "local_provisioning_profile")
+load("@rules_shell//shell:sh_binary.bzl", "sh_binary")
 load(
     "@rules_xcodeproj//xcodeproj:defs.bzl",
     "xcode_provisioning_profile",

diff --git a/bazel/swift_header_collector.bzl b/bazel/swift_header_collector.bzl
@@ -3,6 +3,8 @@ Propagate the generated Swift header from a swift_library target
 This exists to work around https://github.com/bazelbuild/rules_swift/issues/291
 """
 
+load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
+
 def _swift_header_collector(ctx):
     headers = [
         DefaultInfo(

diff --git a/examples/swift/hello_world/BUILD b/examples/swift/hello_world/BUILD
@@ -36,13 +36,13 @@ swift_library(
 ios_application(
     name = "ios_app",
     bundle_id = "io.bitdrift.example.helloworld",
+    entitlements = "Protected.entitlements",
     families = [
         "iphone",
         "ipad",
     ],
     infoplists = ["Info.plist"],
     minimum_os_version = "14.0",
-    entitlements = "Protected.entitlements",
     provisioning_profile = select({
         "//bazel:ios_device_build": "//bazel/ios:ios_provisioning_profile",
         "//conditions:default": None,
@@ -67,12 +67,12 @@ swift_library(
 ios_application(
     name = "hello_world_app",
     bundle_id = "io.bitdrift.example.helloworld",
+    entitlements = "Protected.entitlements",
     families = [
         "iphone",
         "ipad",
     ],
     infoplists = ["Info.plist"],
-    entitlements = "Protected.entitlements",
     minimum_os_version = "14.0",
     provisioning_profile = select({
         "//bazel:ios_device_build": "//bazel/ios:ios_provisioning_profile",

diff --git a/tools/lint/BUILD b/tools/lint/BUILD
@@ -1,4 +1,5 @@
 load("@rules_multirun//:defs.bzl", "multirun", command = "command_force_opt")
+load("@rules_shell//shell:sh_binary.bzl", "sh_binary")
 
 # Commands