workflow: support generate log action #41
Conversation
Along with various math transforms for field generation. Signed-off-by: Matt Klein <[email protected]>
| string message = 1; | ||
| repeated GeneratedField fields = 2; |
There was a problem hiding this comment.
what would be the log level and log type of the generated log? do you want that configurable?
There was a problem hiding this comment.
Yeah good question. We should probably make it configurable. @Reflejo ?
There was a problem hiding this comment.
probably let them set the log level but not the type? I think that's pretty opaque for user consumption
| // Perform subtraction. lhs - rhs. Both values must be convertible to floating point. | ||
| ValueReferencePair subtract = 3; | ||
|
|
||
| // Perform addition. lhs + rhs. Both values must be convertible to floating point. | ||
| ValueReferencePair add = 4; | ||
|
|
||
| // Perform multiplication. lhs * rhs. Both values must be convertible to floating point. | ||
| ValueReferencePair multiply = 5; | ||
|
|
||
| // Perform division. lhs / rhs. Both values must be convertible to floating point. | ||
| ValueReferencePair divide = 6; |
There was a problem hiding this comment.
What happens if the two values are not divisible?
There was a problem hiding this comment.
Another good question. IMO we have 3 options:
- Just drop the field entirely.
- Empty string for value.
- "NaN"
I vote 3. WDYT? @Reflejo
There was a problem hiding this comment.
This is the same for when strings are not numbers, right? NaN makes sense assuming histograms know how to deal with that
There was a problem hiding this comment.
Yeah exactly. I will make sure the histogram code correctly drops NaN stuff.
Along with various math transforms for field generation.