Support custom protocols #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltoe
force-pushed
the
custom-protocols
branch
8 times, most recently
from
d859b15 to
e365e6f
Compare
This patch makes the API more versatile by allowing to run custom protocols. - add :protocol option to `print_to_pdf/2` & `capture_screenshot/2` - refactor API & options handling around `chrome_export/2` - add new top-level but hidden `run_protocol/2` API For the time being, these features are not advertised in the documentation. The `ChromicPDF.Protocol` machinery can be quite tricky and the poor DSL in `ChromicPDF.ProtocolMacros` is subject to change. Nonetheless, this could be a way to avoid adding further options to change and extend the default protocols' behaviour. Relates to #319
maltoe
force-pushed
the
custom-protocols
branch
from
e365e6f to
627c8fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the API more versatile by allowing to run custom protocols.
:protocoloption toprint_to_pdf/2&capture_screenshot/2chrome_export/2run_protocol/2APIFor the time being, these features are not advertised in the documentation. The
ChromicPDF.Protocolmachinery can be quite tricky and the poor DSL inChromicPDF.ProtocolMacrosis subject to change. Nonetheless, this could be a way to avoid adding further options to change and extend the default protocols' behaviour.Relates to #319