Add RPM deck test for Brushless #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is needed for production on CF-BL but it is not any issue of inluding it on other platforms aswell
The limits are not yet decided The test will run for approx 30 sec, and will feed the ESCs with a new PWM signal every 50 msec to prevent it from going asleep. Run one test per motor one at a time.
Keep a local copy instead
These pins will be tested indirectly from the rpm test by reading on them.
ToveRumar
force-pushed
the
toverumar/add_bl_test_deck
branch
2 times, most recently
from
0dbbd58
to
e1a4048
Compare
The ESCs needs to be fed a signal constantly to not go to sleep, however we can not start the test until ESCs are started (which we dont know exactly when that is). To get around this issue we will wait a time, while constantly feeding the ESCs at 1KHz with a 0 PWM signal. After this time we start the test.
ToveRumar
force-pushed
the
toverumar/add_bl_test_deck
branch
from
e1a4048
to
575f7bc
Compare
ToveRumar
force-pushed
the
toverumar/add_bl_test_deck
branch
from
2da1dbb
to
e87e2ba
Compare
tobbeanton
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new test for Brushless that measures the rpm of the propellers at startup.
The limits can be tweaked if needed (maybe after testing with some bad soldering). Tested within a closed box.
The RPM starts fluctuating slightly but the average is pretty much the same.
The BL needs to be stuck in some way for running this test or it will start flying a bit.
I also removed the settings.json file from the repo. Its in .gitignore so its causing issues when mismatched from the checked in version. It is added as a separate commit in this PR