Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sign inconsistencies in pose #396

Open
tobbeanton opened this issue Feb 19, 2019 · 3 comments
Open

Fix sign inconsistencies in pose #396

tobbeanton opened this issue Feb 19, 2019 · 3 comments

Comments

@tobbeanton
Copy link
Member

As described by Wolfgang:
For the negative signs and the power distribution: Unfortunately, there are many inconsistencies in the firmware. You can find a non-exhaustive list here: https://lib.dr.iastate.edu/etd/15575/ (Appendix A). Essentially, those signs compensate for those issues.

It would be good to try to correct this at some point.

@knmcguire
Copy link
Member

Here is the list from that paper:

  • Body axis not aligned with aerospace coordinate system

  • vector accelerator meter-inputs are negative of gravitational vector (in complementary filter)

  • Pitch angle is negated

  • yaw rate is negated before entering mixer

  • q body rate measurement is negated before q-rate PID computation

  • Measured yaw angle is negated before transmission

  • x-position pid controls the roll angle and y position controls the pitch angle

It is quite a lot, but probably it is just a matter of going through it all and make sure we get all the signs. Also documentation on how the coordinate system is defined in the crazyflie would be useful to add as well.

@knmcguire
Copy link
Member

This issue also refers to this: #884

@knmcguire
Copy link
Member

This is related to the bigger SI unit change discussions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants