Skip to content

Conversation

@harding
Copy link
Collaborator

@harding harding commented Sep 6, 2021

Huge thanks to @darosior for the contributed taproot section this week!

@glozow glozow force-pushed the 2021-09-09-newsletter branch from 119ad6a to 75c016a Compare September 6, 2021 13:42
@harding
Copy link
Collaborator Author

harding commented Sep 7, 2021

@glozow pushed a few small suggested edits to your section; please feel to revert anything you don't like. Previewed the content and it LGTM, thanks!

Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few review comments, and also pushed some minor edits to the vaults feature.

Comment on lines 32 to 33
This is about 76.5 vbytes for the cheapest (happy) spending path and about 176.0 vbytes for the costliest (dispute) one.
Compared to the roughly 134.75 vbytes (happy) and 189.5 vbytes (dispute) by using the following P2WSH:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share the calculations for this (perhaps as an html comment)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced this sentence with the vaguer "In taproot, only the leaf being used to spend the output needs to be revealed, so the transaction weight is considerably smaller than for the equivalent P2WSH script:"

Perhaps we can update this with the actual transaction weights later?

@adamjonas adamjonas force-pushed the 2021-09-09-newsletter branch 2 times, most recently from ae8299d to 42e664a Compare September 7, 2021 18:54
@harding
Copy link
Collaborator Author

harding commented Sep 8, 2021

Reviewed contributed PR descriptions (thanks!), made some small edits for that and for feedback (thanks also), and added topic links.

I think there are still a few recommended changes for @glozow if she wants to take them. None seemed critical to me.

@glozow
Copy link
Collaborator

glozow commented Sep 8, 2021

Took the suggestions, sorry for the delay!

@jnewbery
Copy link
Contributor

jnewbery commented Sep 8, 2021

Pushed some additional changes to the @darosior @glozow and @xekyo sections. Everything else looks good to me.

@darosior, could you confirm that you're happy with the new introductory text here: #639 (comment)

@darosior
Copy link
Contributor

darosior commented Sep 8, 2021 via email

@murchandamus
Copy link
Collaborator

Good idea on reordering, @jnewbery. Thanks, changes look good to me.

@bitschmidty bitschmidty force-pushed the 2021-09-09-newsletter branch from cab22e5 to 965b69d Compare September 8, 2021 11:10
@bitschmidty bitschmidty merged commit 178cacd into bitcoinops:master Sep 8, 2021
@bitschmidty
Copy link
Contributor

Thanks @darosior for guest authoring this week, along with @harding @adamjonas @glozow @xekyo @dongcarl and @jnewbery with reviews/edits

@harding
Copy link
Collaborator Author

harding commented Sep 8, 2021

Sorry @darosior for flubbing the definition; thanks @jnewbery for fixing that! Thank you everyone else for all your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants