Skip to content

Conversation

@oleonardolima
Copy link
Collaborator

@oleonardolima oleonardolima commented Feb 26, 2025

Description

In the latest native-tls release 0.2.14 it's bumped their MSRV version to 1.80.0.

It's not a direct dependency, however, it comes as a transitive dependency from reqwest.

Alongside that, the flate2 dependency also bumped their MSRV to 1.67.0 which also requires pinning its version to 1.0.35.

This PR pins on CI both the native-tls to 0.2.13, and flate2 to 1.0.35, and updates the instruction on README.md in order to properly build on MSRV.

Notes to the reviewers

Changelog notice

  • Adds native-tls 0.2.13 to MSRV pinning step on CI.
  • Adds flate2 1.0.35 to MSRV pinning step on CI.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@coveralls
Copy link

coveralls commented Feb 26, 2025

Pull Request Test Coverage Report for Build 13551188773

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 88.167%

Files with Coverage Reduction New Missed Lines %
src/api.rs 1 53.03%
Totals Coverage Status
Change from base Build 12165803391: -0.2%
Covered Lines: 1140
Relevant Lines: 1293

💛 - Coveralls

@oleonardolima oleonardolima changed the title fix(ci): pin native-tls to 0.2.13 fix(ci): pin native-tls to 0.2.13 and flate2 to 1.0.35 Feb 26, 2025
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 84161ba

@ValuedMammal ValuedMammal merged commit 9c9e7a5 into bitcoindevkit:master Feb 26, 2025
25 checks passed
@oleonardolima oleonardolima deleted the ci/pin-native-tls-to-0.2.13 branch March 20, 2025 15:07
chrono-raven6i90 added a commit to chrono-raven6i90/rust-esplora-client that referenced this pull request Oct 28, 2025
…` to `0.2.13` and `flate2` to `1.0.35`

84161bafbc345cb7faf48721e5682afd5213894b fix(ci): pint `flate2` to `1.0.35` (Leonardo Lima)
1aeb466ddfa1d89820275c8df89075aa79c8dffa fix(ci): pin `native-tls` to `0.2.13` (Leonardo Lima)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  In the latest `native-tls` release [`0.2.14`](https://github.com/sfackler/rust-native-tls/releases/tag/v0.2.14) it's bumped their MSRV version to `1.80.0`.

  It's not a direct dependency, however, it comes as a transitive dependency from `reqwest`.

  Alongside that, the `flate2` dependency also bumped their MSRV to `1.67.0` which also requires pinning its version to `1.0.35`.

  This PR pins on CI both the `native-tls` to `0.2.13`, and `flate2` to `1.0.35`, and updates the instruction on `README.md` in order to properly build on MSRV.

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Changelog notice

  - Adds `native-tls 0.2.13` to MSRV pinning step on CI.
  - Adds `flate2 1.0.35` to MSRV pinning step on CI.

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  <!--
  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

  -->

ACKs for top commit:
  ValuedMammal:
    ACK 84161bafbc345cb7faf48721e5682afd5213894b

Tree-SHA512: 2b092afb8cd673e66cf7443ebbc21da1bbb4aaa0a7913374b09eb1d2fd91a2eaab5ce2a4367d987f8b866da82c3cd985b1638c0d6d8cab61bcf68087a3ae12b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants