Skip to content

Conversation

@notmandatory
Copy link
Member

No description provided.

@notmandatory notmandatory self-assigned this Nov 22, 2024
@notmandatory notmandatory added the duplicate This issue or pull request already exists label Nov 22, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11965461318

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.426%

Totals Coverage Status
Change from base Build 11919574336: 0.0%
Covered Lines: 1146
Relevant Lines: 1296

💛 - Coveralls

Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e2bd28b

@LagginTimes
Copy link

ACK e2bd28b

@notmandatory notmandatory removed the duplicate This issue or pull request already exists label Nov 26, 2024
@notmandatory
Copy link
Member Author

notmandatory commented Nov 26, 2024

The security-framework-sys crate bumped their MSRV to 1.65 18 days ago so for our MSRV of 1.63 we need to pin it back to 2.11.1. I'm not sure why CI didn't catch this when I made this PR 4 days ago. The CI build steps fail when I run them locally for 1.63.

Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 23485a9

@LagginTimes
Copy link

ACK 23485a9

@ValuedMammal ValuedMammal merged commit 8f49c84 into bitcoindevkit:master Dec 4, 2024
25 checks passed
chrono-raven6i90 added a commit to chrono-raven6i90/rust-esplora-client that referenced this pull request Oct 28, 2025
….11.0

23485a95e07c1ba8044634117366f6f7ca29fdf8 ci: pin msrv dep version for security-framework-sys (Steve Myers)
e2bd28b86f8cf0585f8eb0fb9d5f65024abbc369 chore: bump version to 0.11.0 (Steve Myers)

Pull request description:

ACKs for top commit:
  LagginTimes:
    ACK 23485a95e07c1ba8044634117366f6f7ca29fdf8
  ValuedMammal:
    ACK 23485a95e07c1ba8044634117366f6f7ca29fdf8

Tree-SHA512: 45e8538d8feb80c5afc983c2d67dcc0f32ebdf77cfda8c6ee2c0a121b2ca826fe68db9e69e2475ee5e611144ddda86b0963b96584b5e2c6d3de0bad548a3db38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants