Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Deref<Target=Client> for ElectrumBlockchain #705

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Implement Deref<Target=Client> for ElectrumBlockchain #705

merged 1 commit into from
Aug 25, 2022

Conversation

afilini
Copy link
Member

@afilini afilini commented Aug 8, 2022

Description

As pointed out in bitcoindevkit/rust-electrum-client#58 (comment) there was no way to keep using the client once it was given to BDK.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@afilini
Implement Deref<Target=Client> for ElectrumBlockchain
c5952dd 
As pointed out in bitcoindevkit/rust-electrum-client#58 (comment)
there was no way to keep using the client once it was given to BDK.
@tnull
Copy link
Contributor

tnull commented Aug 8, 2022

Thank you for having a look at this! Could you also add the same for EsploraClient?

vladimirfomene added a commit to vladimirfomene/bdk that referenced this pull request Aug 15, 2022
@vladimirfomene
Implement Deref<Target=UrlClient> for EsploraBlockchain
d137119 
There is currently no way to access the client
from the EsploraBlockchain. This makes it difficult
for users to extend it's functionality. This PR exposes
both the reqwest and ureq clients. This PR is related to
PR bitcoindevkit#705.
@vladimirfomene vladimirfomene mentioned this pull request Aug 15, 2022
Closed
3 tasks
@vladimirfomene
Copy link
Contributor

vladimirfomene commented Aug 15, 2022 •
edited
Loading

@afilini #722 implements this for our Esplora clients. I just created it in case this is needed urgently. This will change a bit once we refactor our Esplorablockchain code to incoroporate our new rust-esplora-client

@tnull
Copy link
Contributor

tnull commented Aug 15, 2022 •
edited
Loading

@afilini #720 implements this for our Esplora clients. I just created it in case this is needed urgently. This will change a bit once we refactor our Esplorablockchain code to incoroporate our new rust-esplora-client

Thanks for having a look a this! @afilini also created a BDK branch that makes use of the updated external rust-esplora-client (https://github.com/afilini/bdk/tree/feat/use-external-esplora-client), which implements this. I'm currently tracking this branch for my development.

vladimirfomene added a commit to vladimirfomene/bdk that referenced this pull request Aug 15, 2022
@vladimirfomene
Implement Deref<Target=UrlClient> for EsploraBlockchain
d8a87e9 
There is currently no way to access the client
from the EsploraBlockchain. This makes it difficult
for users to extend it's functionality. This PR exposes
both the reqwest and ureq clients. This PR is related to
PR bitcoindevkit#705.
vladimirfomene added a commit to vladimirfomene/bdk that referenced this pull request Aug 15, 2022
@vladimirfomene
Implement Deref<Target=UrlClient> for EsploraBlockchain
2b4ad4c 
There is currently no way to access the client
from the EsploraBlockchain. This makes it difficult
for users to extend it's functionality. This PR exposes
both the reqwest and ureq clients. This PR is related to
PR bitcoindevkit#705.
@vladimirfomene vladimirfomene mentioned this pull request Aug 15, 2022
Closed
3 tasks
vladimirfomene added a commit to vladimirfomene/bdk that referenced this pull request Aug 15, 2022
@vladimirfomene
Implement Deref<Target=UrlClient> for EsploraBlockchain
390fe6d 
There is currently no way to access the client
from the EsploraBlockchain. This makes it difficult
for users to extend it's functionality. This PR exposes
both the reqwest and ureq clients. This PR is related to
PR bitcoindevkit#705.
vladimirfomene added a commit to vladimirfomene/bdk that referenced this pull request Aug 15, 2022
@vladimirfomene
Implement Deref<Target=UrlClient> for EsploraBlockchain
cd0ae98 
There is currently no way to access the client
from the EsploraBlockchain. This makes it difficult
for users to extend it's functionality. This PR exposes
both the reqwest and ureq clients. This PR is related to
PR bitcoindevkit#705.
vladimirfomene added a commit to vladimirfomene/bdk that referenced this pull request Aug 15, 2022
@vladimirfomene
Implement Deref<Target=UrlClient> for EsploraBlockchain
9e32b3a 
There is currently no way to access the client
from the EsploraBlockchain. This makes it difficult
for users to extend it's functionality. This PR exposes
both the reqwest and ureq clients. This PR is related to
PR bitcoindevkit#705.
vladimirfomene added a commit to vladimirfomene/bdk that referenced this pull request Aug 15, 2022
@vladimirfomene
Implement Deref<Target=UrlClient> for EsploraBlockchain
baf7eaa 
There is currently no way to access the client
from the EsploraBlockchain. This makes it difficult
for users to extend it's functionality. This PR exposes
both the reqwest and ureq clients. This PR is related to
PR bitcoindevkit#705.
@vladimirfomene vladimirfomene mentioned this pull request Aug 15, 2022
Merged
3 tasks
rajarshimaitra
rajarshimaitra approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c5952dd

@rajarshimaitra rajarshimaitra mentioned this pull request Aug 23, 2022
Merged
3 tasks
afilini added a commit that referenced this pull request Aug 25, 2022
@afilini
Merge #731: Implement Deref<Target=Client> for RpcBlockchain
34e792e 
a8f9f6c RpcBlockchain derefs to the underlying RPC Client (rajarshimaitra)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  For the same reason as #705  and #722 ..

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  afilini:
    ACK a8f9f6c

Tree-SHA512: 81e596fe451c275ca0ce27ee7ac9cf7e88433775603021c2dd1cd26a26558531cf74f81ef05d0ae9d5d0e59e91196e3ac6d38c0f4853b1889ddf822d8e63e178
@afilini afilini merged commit 7bc2980 into bitcoindevkit:master Aug 25, 2022
afilini added a commit that referenced this pull request Aug 25, 2022
@afilini
Merge #722: Implement Deref<Target=UrlClient> for EsploraBlockchain
a5d1a3d 
baf7eaa Implement Deref<Target=UrlClient> for EsploraBlockchain (Vladimir Fomene)

Pull request description:

  ### Description

  There is currently no way to access the client from the EsploraBlockchain. This makes it difficult for users to extend it's functionality. This PR exposes both the reqwest and ureq clients. This PR is related to PR #705.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  rajarshimaitra:
    tACK baf7eaa

Tree-SHA512: e2f530058c88e06fc2972edfcd2df1b534d43b0214d710b62e4d5200ac0e38dad6a9f8db1e0c7a7ed19892e59411dcc07f3f6dc8ad58afae9d677169ca98bb38
@afilini afilini mentioned this pull request Sep 8, 2022
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajarshimaitra rajarshimaitra rajarshimaitra approved these changes

Assignees

@afilini afilini

Labels
None yet
Projects
None yet
Milestone
Release 0.22.0 Feature Freeze
Development

Successfully merging this pull request may close these issues.
5 participants
@afilini @tnull @vladimirfomene @rajarshimaitra @notmandatory