Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rpc backend to the AnyBlockchain #407

Merged
merged 4 commits into from
Jul 28, 2021
Merged

Conversation

RCasatta
Copy link
Member

Description

Add Rpc as AnyBlockchain

Should enable to use Rpc backend in bdk-cli

Notes to the reviewers

I was waiting for rust-bitcoin/rust-bitcoincore-rpc#181 but I was tired waiting so I think we can have this workaround here until upstream is merged and released (serialized format should be the same)

alternative to #405

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've updated CHANGELOG.md

Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good.

Ran the tests manually.

I would start working on exposing this via bdk-cli, also maybe a small tutorial showing an easy connection between bdk and core backend.

@afilini afilini merged commit 2b0c4f0 into bitcoindevkit:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants