-
Notifications
You must be signed in to change notification settings - Fork 412
deps(esplora): bump esplora-client to 0.11.0
#1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(esplora): bump esplora-client to 0.11.0
#1746
Conversation
oleonardolima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
❓ I think this Lines 29 to 31 in f6c1c61
|
165e503 to
90fd1a2
Compare
You're right, |
notmandatory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 90fd1a2
I manually tested the three esplora examples and they are all working fine.
| [dependencies] | ||
| bdk_core = { path = "../core", version = "0.3.0", default-features = false } | ||
| esplora-client = { version = "0.10.0", default-features = false } | ||
| esplora-client = { version = "0.11.0", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: there's a trailing whitespace here
| esplora-client = { version = "0.11.0", default-features = false } | |
| esplora-client = { version = "0.11.0", default-features = false } |
oleonardolima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 90fd1a2
Update
bdk_esplorato depend on esplora-client 0.11.0Notes to the reviewers
bitcoindevkit/rust-esplora-client#103 added a generic type parameter to
AsyncClientrepresenting a user-definedSleeperand that change is reflected here in order to call the underlying API methods. We also add a new build feature "tokio" that enables the corresponding feature in rust-esplora-client.closes #1742
Changelog notice
bdk_esplora: Bumpesplora-clientto 0.11.0Checklists
All Submissions:
cargo fmtandcargo clippybefore committing