test(wallet): create tx locktime cltv for a specific time #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3r10
changed the title
| /// the parameter passed to miniscript fragment `after` has to equal or grather than 500_000_000 | ||
| /// in order to use a lock based on unix time | ||
| pub fn get_test_single_sig_cltv_for_specific_time() -> &'static str { | ||
| "wsh(and_v(v:pk(cVpPVruEDdmutPzisEsYvtST1usBR3ntr8pXSyt6D2YYqXRyPcFW),after(500000000)))" |
There was a problem hiding this comment.
⛏️ just a nit but we should use a timestamp that's sometime after the genesis block. Sometimes people use these tests as examples so will make more sense to use a more recent time. Also the number is easier to read in the code with the underscores.
Suggested change
| "wsh(and_v(v:pk(cVpPVruEDdmutPzisEsYvtST1usBR3ntr8pXSyt6D2YYqXRyPcFW),after(500000000)))" | |
| "wsh(and_v(v:pk(cVpPVruEDdmutPzisEsYvtST1usBR3ntr8pXSyt6D2YYqXRyPcFW),after(1_734_230_218)))" |
There was a problem hiding this comment.
I tried to update the descriptor as you mentioned, but there is an error with the format:
descriptors must be valid: Miniscript(Unexpected("unexpected «1_734_230_218»"))
It looks like miniscript does not have support for numbers with underscores.
| @@ -160,6 +160,13 @@ pub fn get_test_single_sig_cltv() -> &'static str { | |||
| "wsh(and_v(v:pk(cVpPVruEDdmutPzisEsYvtST1usBR3ntr8pXSyt6D2YYqXRyPcFW),after(100000)))" | |||
| } | |||
|
|
|||
| /// `wsh` descriptor with policy `and(pk(A),after(500_000_000))` | |||
| /// the parameter passed to miniscript fragment `after` has to equal or grather than 500_000_000 | |||
There was a problem hiding this comment.
Suggested change
| /// the parameter passed to miniscript fragment `after` has to equal or grather than 500_000_000 | |
| /// the parameter passed to miniscript fragment `after` has to equal or greater than 500_000_000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a unit test that checks the satisfaction of timestamp-based timelocks. The goal is to test the absolute time therefore the variable passed to the miniscript fragment
afterhas to be equal to or greater that 500_000_000 otherwise it would be checking the block height.Notes to the reviewers
This unit test tries to check if #642 is still an issue.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing