Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1536
Description
Based on the discussion about single-keychain wallets on Tuesday, I couldn't stop myself from experimenting with an any-keychain-count wallet. This is done by introducing a type parameter to
Wallet<K>
.This is obviously a breaking change, but this seems to be the only non-hacky solution for the problem. The only downside is that a whole bunch of wallet methods now return
Option
since we can have keychains without corresponding descriptors.TxBuilder
parameters have been refactored to make sense in this context.ChangeSet
has been refactored to allow for any keychain count.Notes to the reviewers
It's building with
cargo build -p bdk_wallet
. The tests do not compile.To see something that has a bigger chance of being merged, check out #1533.
Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
Bugfixes: