Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Multi-descriptor wallet #1539

Conversation

evanlinjin
Copy link
Member

@evanlinjin evanlinjin commented Aug 7, 2024

Closes #1536

Description

Based on the discussion about single-keychain wallets on Tuesday, I couldn't stop myself from experimenting with an any-keychain-count wallet. This is done by introducing a type parameter to Wallet<K>.

This is obviously a breaking change, but this seems to be the only non-hacky solution for the problem. The only downside is that a whole bunch of wallet methods now return Option since we can have keychains without corresponding descriptors.

TxBuilder parameters have been refactored to make sense in this context.

ChangeSet has been refactored to allow for any keychain count.

Notes to the reviewers

It's building with cargo build -p bdk_wallet. The tests do not compile.

To see something that has a bigger chance of being merged, check out #1533.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@evanlinjin evanlinjin force-pushed the wallet_with_keychain_type_parameter branch from c88ab2a to 890e1c4 Compare August 7, 2024 12:01
@notmandatory
Copy link
Member

Concept ACK for the 2.0 milestone.

For 1.0 the priority should be on API stability which #1533 accomplishes in a less disruptive way.

@evanlinjin
Copy link
Member Author

Closing because I can't see this coming to light.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Should the Wallet have a generic keychain K?
2 participants