Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Address type in address field on AddressInfo #333

Merged
merged 5 commits into from
Mar 30, 2023

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Mar 28, 2023

This PR leverages the newly exposed methods on the Address type and uses that in the AddressInfo type instead of a address string.

Description

Fixes #332.

Notes to the reviewers

As with the descriptor type, I'm changing the to_string() method to as_string() in the FFI. I don't remember why we made this choice way back when. Is that because of the name clash with the toString() methods on Kotlin and Swift? Just looking for validation before locking the API in.

Changelog notice

API Changes
- address field on `AddressInfo` type is now of type `Address` [#333]

[#333]: https://github.com/bitcoindevkit/bdk-ffi/pull/333

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've fixed the tests for the new feature
  • I've added docs for the new feature

@thunderbiscuit thunderbiscuit added this to the Release 0.28.0 milestone Mar 28, 2023
@thunderbiscuit thunderbiscuit self-assigned this Mar 28, 2023
@thunderbiscuit thunderbiscuit force-pushed the feat/addressinfo branch 2 times, most recently from 8173c7e to 361bf47 Compare March 28, 2023 19:01
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5ee8698

Thanks for the extra cleanups !

@thunderbiscuit thunderbiscuit merged commit 5ee8698 into bitcoindevkit:master Mar 30, 2023
@thunderbiscuit thunderbiscuit deleted the feat/addressinfo branch November 14, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Mirror AddressInfo API from Rust BDK
2 participants