Use Address type in address field on AddressInfo #333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages the newly exposed methods on the
Address
type and uses that in the AddressInfo type instead of a address string.Description
Fixes #332.
Notes to the reviewers
As with the descriptor type, I'm changing the
to_string()
method toas_string()
in the FFI. I don't remember why we made this choice way back when. Is that because of the name clash with the toString() methods on Kotlin and Swift? Just looking for validation before locking the API in.Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features: