Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uniffi-bindgen to 0.19.5 #194

Merged

Conversation

thunderbiscuit
Copy link
Member

As per mozilla/uniffi-rs#1322, the new argument introduced in the generate_bindings() function should be set to None unless we use the new macro-based approach.

This PR unpins the uniffi-bindgen library while also ensuring the CI can build the library properly.

@thunderbiscuit thunderbiscuit self-assigned this Sep 2, 2022
@thunderbiscuit thunderbiscuit added this to the Release 0.9.0 milestone Sep 2, 2022
@thunderbiscuit
Copy link
Member Author

Ok so now we're getting an error because of 0.19.6. Hold on while I figure this out.

@thunderbiscuit
Copy link
Member Author

We need to update the version of the Rust compiler used in the CI:

mozilla/uniffi-rs#1322 (comment)

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8166f82

@thunderbiscuit thunderbiscuit merged commit 297680b into bitcoindevkit:master Sep 5, 2022
@thunderbiscuit thunderbiscuit deleted the update/uniffi-bindgen branch November 14, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants